Master #1

ddppqq · 2014-06-29T09:08:54Z

merge

Add documentation and examples for the .definefilter, .activatefilter, and .deactivatefilter directives in remap.config. These docs are specifically restricted to these particular names because (1) we should standardize on one variant for each of these directives to avoid end-user confusion and (2) I personally believe these variants to be the clearest and most understandable ("defflt", "useflt", "deuseflt", etc., are confusing or awkward). The .deletefilter directive is not documented, because I am not sure when or why it would be used.

@action

Add line continuation to remap.config using a backslash at the end of a line as the continuation character. The handling for continuation was made in tokLine() by adding an optional third char parameter (`cont') which is the continuation character. This should make it usable in other contexts outside of remap.config also, for example other config file parsers. This implementation is not very intelligent, as it only checks for the backslash immediately preceding the newline and does not handle any whitespace. The backslash and newline are converted into spaces, and the next line is appended. Example: .definefilter foo \ @action=allow \ @src_ip=127.0.0.1 is read and parsed in UrlRewrite::BuildTable() as: .definefilter foo @action=allow @src_ip=127.0.0.1

libloader has been considered as stable since it's donation, but it wasn't put into the build by default. We change this now, and we add a convention for how to add plugins in the future.

The Logging module use uint16_t(LogBuffer->m_state.s.m_offset/byte_count) to store log buffer size. It's very dangerous for user, as there are not any warning when user breaks the limitation. In our environment, we set the log_buffer_size to 512KB(and set max_entries_per_buffer to 1000), it make ATS crashing. This patch enlarge the limitation from 64KB to 4GB by merging *offset* and *byte_count* variables into one, so that we can use uint32_t to store the buffer size. Signed-off-by: Yunkai Zhang <[email protected]>

When the configurable value of max_entries_per_buffer in LogHost is smaller that LogClient, it'll lead to log dropped silently. Actually, after we fix https://issues.apache.org/jira/browse/TS-2122 issue, the max_entries_per_buffer option is unnecessary now. Let's remove it to avoid traps caused by it. Signed-off-by: Yunkai Zhang <[email protected]>

1) Avoid silently dropping log entries in write_ascii_logbuffer3(). 2) Remove overspill logic, and try to write log to disk as much as possible. 3) Simplify the code by removing unecessary *overspill* variables. Signed-off-by: Yunkai Zhang <[email protected]>

Signed-off-by: Yunkai Zhang <[email protected]>

Added 'arch' (Architecture) section. Added cache documents. Fixed many warnings. Added Tiered Storage proposal.

AC_SEARCH_LIBS always updates $LIBS, but AC_CHECK_LIB doesn't search properly. So we have to introduce a wrapper around AC_SEARCH_LIBS that preserves $LIBS so that we can properly test for libraries without linking them into everything. Apply the new TS_SEARCH_LIBRARY macro to the geoip_acl plugin so that libGeoIP is not linked into every binary.

We were passing a format string to SSLDiagnostic(), but never actually using it when we logged the error. Improve the ssl_multicert.config error logging so that we log the file and line of where we detected an error.

Looks like m4_ifval isn't present in older versions of m4, however m4_default is probably a better choice anyway.

Now, in LogHost::write (LogBuffer *lb), Another new LogBuffer object will be allocated to copy the content of *lb* parameter. But *lb* will be deleted by the upper function, LogBufferManager::flush_buffers(), after LogHost::write() return. Obviously, the copy is unnecessary, and may cause memory fragmentation. Let's optimize it. Signed-off-by: Yunkai Zhang <[email protected]>

Calling "make install" sets ${localstatedir} owner and group to "ats" user. Needlessly so. This patch fixes it.

Older automake (< 1.9?) doesn't emit $(builddir), but it's always "." anyway, so let's use that instead.

1) Use nonblock eventfd, so that we can tolerate write() failed with errno EAGANIN – which is acceptable as the signal receiver will be notified eventually in this case. 2) After using nonblock eventfd, read() will not block in wait(). So I use epoll_wait() to implement block behavior, just like timedwait(). 3) nonblock eventfd can fix a potential problem: if receiver didn't read() data immediately, senders might block in write(). Signed-off-by: Yunkai Zhang <[email protected]>

Signed-off-by: Yunkai Zhang <[email protected]>

will result in empty responses

Signed-off-by: Yunkai Zhang <[email protected]>

…message and other handle Reliable(TCP) request.

Ubuntu Saucy (13.10) will be out of beta soon and comes with many goodies: Most prominently: clang 3.4 (and also clang-format). Right now we're still throwing a bunch of warnings when compiling with clang 3.4, so I'm adding support now that we can work on it asap.

2 cluster parameters: proxy.config.cluster.flow_ctrl.min_send_wait_time proxy.config.cluster.flow_ctrl.max_send_wait_time

in mgmt/RecordsConfig.cc, add two miessed cluster parameters: proxy.config.cluster.ping_retries proxy.config.cluster.connections

mingzym · 2014-06-30T08:36:38Z

what is the merge want to do?

CLAassistant · 2019-11-07T07:03:06Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 7 committers have signed the CLA.

❌ Nick Kew
❌ bryancall
❌ jpeach
❌ yunkai
❌ zwoop
❌ scottharris
❌ igalic

Nick Kew seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

igalic and others added 30 commits August 6, 2013 13:12

TS-1953: close this by adding an example & CHANGES

a7708df

TS-2102 SPDY plugin tries to setup protocol handler too early.

c1c963e

TS-2051: Fix SSL crash due to excess READ_COMPLETE events.

8448668

Updated with TS-2099

c612971

Bumped to v3.5.0

233cf63

Fixed a few very minor RAT warnings, non-issues just warnings

695c2ab

TS-2111 Reduce Boost requirement to v1.33 or later

eaa7600

TS-2112: make libloader compile by default

c8725ba

libloader has been considered as stable since it's donation, but it wasn't put into the build by default. We change this now, and we add a convention for how to add plugins in the future.

Documentation - Added domain, updated for ts:confvar -> ts:cv

8d71223

doc: update ssl_multicert.config documentation

689c620

doc: add config variable references

c78a4f8

docs: update sphinx documentation version

3fad79d

Fix warning by adding space between " and PRIu32

2af1cb2

Signed-off-by: Yunkai Zhang <[email protected]>

Updated with recent changes.

6e5374f

TS-2123 Also remove it from AdminClient.pm.

53ae4b9

Documentation: Fixed a few warnings.

8ecd7e6

Documentation:

7c21e68

Added 'arch' (Architecture) section. Added cache documents. Fixed many warnings. Added Tiered Storage proposal.

Documentation: random warning / cross reference cleanup.

92961cf

TS-2129 Check for existence of ExtUtils::MakeMaker

3f2b113

TS-2096: improve SSL certificate loading error messages

aeea92c

We were passing a format string to SSLDiagnostic(), but never actually using it when we logged the error. Improve the ssl_multicert.config error logging so that we log the file and line of where we detected an error.

TS-2128: Fix TS_SEARCH_LIBRARY for RHEL5

ca7b063

Looks like m4_ifval isn't present in older versions of m4, however m4_default is probably a better choice anyway.

TS-2130: pthread_setname_np() detection fails on various platforms

f390a8e

TS-2131: ${localstatedir} chowned to ATS' user

26a3323

Calling "make install" sets ${localstatedir} owner and group to "ats" user. Needlessly so. This patch fixes it.

jpeach and others added 28 commits September 10, 2013 09:21

TS-2207: stop using $(builddir) in automake

00b8856

Older automake (< 1.9?) doesn't emit $(builddir), but it's always "." anyway, so let's use that instead.

Fixed indentation

b6e2132

ci: all centos versions have redhat-lsb

40212d2

TS-2187: Fix return in EventNotify::wait()

2e4ee7b

Signed-off-by: Yunkai Zhang <[email protected]>

TS-2209 add support for lowercasing all substitutions in regex_remap

2c0ea4e

udpated release notes

9e9569f

TS-2217: remove the option to turn off body factory - setting it to 0

cb9e4b5

will result in empty responses

TS-2144 Avoid race on e.g. -Cclear which would crash the process

b5edc06

Added TS-2144.

f3fa606

Update docs for the header_rewrite plugin

4fab19a

comment on the units for TSContScheduleEvery()

93184bb

TS-2187: 'nr' set but not used in EventNotify::signal()

f47c6be

Signed-off-by: Yunkai Zhang <[email protected]>

TS-2201: split drainIncomingChannel two thread, one handle Broadcast …

3a903f2

…message and other handle Reliable(TCP) request.

Fix typo in the hook used

8409434

TS-2232: log level should be change from Status to Debug

1ec3990

refine the codes of cluster

62504a9

session stats can be read by "traffic_line -r"

fb93698

change the default value to 0

f08fc4e

2 cluster parameters: proxy.config.cluster.flow_ctrl.min_send_wait_time proxy.config.cluster.flow_ctrl.max_send_wait_time

should declare int result

cb0b2b5

remove compile warning

13c9f7c

register two missed cluster parameters

ea26ddb

in mgmt/RecordsConfig.cc, add two miessed cluster parameters: proxy.config.cluster.ping_retries proxy.config.cluster.connections

change Warning to Debug for inconsistent time

089d16d

new remap format

159b1d3

remove compile warnings

1e63f07

remove useless AclFiltering.h and AclFiltering.cc

38d553b

correct spell of overridablehttpConfig

b02f4ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master #1

Master #1

ddppqq commented Jun 29, 2014

mingzym commented Jun 30, 2014

CLAassistant commented Nov 7, 2019 •

edited

Loading

Master #1

Are you sure you want to change the base?

Master #1

Conversation

ddppqq commented Jun 29, 2014

mingzym commented Jun 30, 2014

CLAassistant commented Nov 7, 2019 • edited Loading

CLAassistant commented Nov 7, 2019 •

edited

Loading