Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add computeGroupId support in Encoder #21

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat: Add computeGroupId support in Encoder #21

merged 3 commits into from
Feb 13, 2025

Conversation

ehanoc
Copy link
Collaborator

@ehanoc ehanoc commented Feb 13, 2025

Adding computeGroupId to AlgorandEncoder

@ehanoc ehanoc added enhancement New feature or request feature labels Feb 13, 2025
@ehanoc ehanoc requested a review from PhearZero February 13, 2025 14:12
PhearZero
PhearZero approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Manually tested a few combinations and seems to be accurate 🕺

@ehanoc ehanoc merged commit 0f6f872 into main Feb 13, 2025
2 checks passed
@engineering-ci
Copy link

🎉 This PR is included in version 1.0.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhearZero PhearZero PhearZero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request feature released on @main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehanoc @PhearZero