tests: fix TestSendSigsAfterCatchpointCatchup #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
approved these changes
Feb 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6244 +/- ##
==========================================
- Coverage 51.76% 51.37% -0.39%
==========================================
Files 644 644
Lines 86521 86521
==========================================
- Hits 44786 44453 -333
- Misses 38870 39170 +300
- Partials 2865 2898 +33 ☔ View full report in Codecov by Sentry. |
jannotti
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6224, the changes to verify the catchpoint file generated did not wait long enough, due to code ordering before it was downloaded.
Test Plan
Nightly tests should now pass.