Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add -d and -o args for catchpointdump net, like file, new info command #6235

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 25, 2025

Summary

This adds a new info command to catchpointdump, and adds the file command's -d and -o flags to the net command (a small change because net already shares code with file).

Test Plan

Tools only change, existing tests should pass.

@cce cce force-pushed the catchpointdump-info branch from fb713e2 to 7162784 Compare January 25, 2025 18:01
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 138 lines in your changes missing coverage. Please review.

Project coverage is 51.76%. Comparing base (8d01230) to head (956cfda).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/catchpointdump/info.go 0.00% 131 Missing ⚠️
cmd/catchpointdump/net.go 0.00% 6 Missing ⚠️
cmd/catchpointdump/commands.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6235      +/-   ##
==========================================
+ Coverage   51.53%   51.76%   +0.23%     
==========================================
  Files         643      644       +1     
  Lines       86382    86519     +137     
==========================================
+ Hits        44513    44783     +270     
+ Misses      38976    38868     -108     
+ Partials     2893     2868      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

algorandskiy
algorandskiy previously approved these changes Jan 26, 2025
algorandskiy
algorandskiy previously approved these changes Jan 28, 2025
@algorandskiy algorandskiy merged commit 8832ed5 into algorand:master Jan 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants