-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add -d and -o args for catchpointdump net, like file, new info command #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
force-pushed
the
catchpointdump-info
branch
from
January 25, 2025 18:01
fb713e2
to
7162784
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6235 +/- ##
==========================================
+ Coverage 51.53% 51.76% +0.23%
==========================================
Files 643 644 +1
Lines 86382 86519 +137
==========================================
+ Hits 44513 44783 +270
+ Misses 38976 38868 -108
+ Partials 2893 2868 -25 ☔ View full report in Codecov by Sentry. |
algorandskiy
previously approved these changes
Jan 26, 2025
algorandskiy
previously approved these changes
Jan 28, 2025
algorandskiy
approved these changes
Jan 29, 2025
gmalouf
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
info
command to catchpointdump, and adds thefile
command's-d
and-o
flags to thenet
command (a small change becausenet
already shares code withfile
).Test Plan
Tools only change, existing tests should pass.