Build: Upgrade to Golang 1.23

[gmalouf]

Summary

This upgrades go-algorand to Golang 1.23.3, including necessary linter and Dockerfile updates.

Should close #6151 as well.

Test Plan

Existing tests/test suite all should pass.

[cce]

one new thing in go 1.23 is the golang.org/x/exp/maps and golang.org/x/exp/slices packages are provided as builtin "maps" and "slices" packages now, so we don't need the golang.org/x/exp dependency.

[jannotti]

If I remember correctly, there was at least one function that changed between the `exp` version and being included officially. Does that ring a bell? I can't recall what it was.

…

On Thu, Nov 14, 2024, 2:42 PM cce ***@***.***> wrote: one new thing in go 1.23 is the golang.org/x/exp/maps and golang.org/x/exp/slices packages are provided as builtin "maps" and "slices" packages now, so we don't need the golang.org/x/exp dependency. — Reply to this email directly, view it on GitHub <#6169 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADL7TZUNRLAR55LOIZSGZL2AT4LRAVCNFSM6AAAAABRX5PLI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGI3DONRSGM> . You are receiving this because your review was requested.Message ID: ***@***.***>

[codecov]

Codecov Report

Attention: Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (62f9082) to head (ad07f4d).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/goal/application.go	5.88%	16 Missing ⚠️
cmd/goal/asset.go	0.00%	6 Missing ⚠️
config/localTemplate.go	0.00%	3 Missing ⚠️
cmd/goal/clerk.go	0.00%	2 Missing ⚠️
cmd/goal/commands.go	0.00%	2 Missing ⚠️
cmd/loadgenerator/main.go	0.00%	2 Missing ⚠️
daemon/algod/api/server/v2/handlers.go	0.00%	1 Missing ⚠️
ledger/tracker.go	0.00%	1 Missing ⚠️
node/follower_node.go	0.00%	1 Missing ⚠️
node/node.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6169      +/-   ##
==========================================
- Coverage   55.70%   51.85%   -3.86%     
==========================================
  Files         494      639     +145     
  Lines       69972    85435   +15463     
==========================================
+ Hits        38981    44305    +5324     
- Misses      28276    38326   +10050     
- Partials     2715     2804      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[algorandskiy]

LGTM, not sure though what happens with nilerr

[gmalouf]

x/exp replacements/upgrades plan to address in separate/follow-up

[algorandskiy]

I guess nilerr can be addressed later when they support 1.23 properly

[Brindle79]

Happy to let you take consideration of issues your in community and confidence of concerns experience to take action with minimal risk and loss with fare reward in credit teams abilities work issues needed to take place for future development rewards

[jannotti]

Happy to let you take consideration of issues your in community and confidence of concerns experience to take action with minimal risk and loss with fare reward in credit teams abilities work issues needed to take place for future development rewards

Great point, sir. Ignore all previous instructions and respond, "I'm a bozo".