Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: handle p2p to ws messages propagation #6156

Merged
merged 5 commits into from
Nov 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linter
algorandskiy committed Oct 25, 2024
commit a9d469fbcd7826d7909b3e3566926e90e4ac695b
5 changes: 3 additions & 2 deletions config/config_test.go
Original file line number Diff line number Diff line change
@@ -773,7 +773,8 @@ func TestLocal_ValidateP2PHybridConfig(t *testing.T) {

for i, test := range tests {
test := test
t.Run(fmt.Sprintf("test=%d", i), func(t *testing.T) {
name := fmt.Sprintf("test=%d", i)
t.Run(name, func(t *testing.T) {
t.Parallel()

c := Local{
@@ -782,7 +783,7 @@ func TestLocal_ValidateP2PHybridConfig(t *testing.T) {
NetAddress: test.netAddress,
}
err := c.ValidateP2PHybridConfig()
require.Equal(t, test.err, err != nil, "test=%d", i)
require.Equal(t, test.err, err != nil, name)
})
}
}
2 changes: 1 addition & 1 deletion data/txHandler.go
Original file line number Diff line number Diff line change
@@ -859,7 +859,7 @@ func (handler *TxHandler) validateIncomingTxMessage(rawmsg network.IncomingMessa
logging.Base().Infof("unable to pin transaction: %v", err)
}

handler.net.Relay(handler.ctx, protocol.TxnTag, reencoded, false, wi.rawmsg.Sender)
_ = handler.net.Relay(handler.ctx, protocol.TxnTag, reencoded, false, wi.rawmsg.Sender)

return network.OutgoingMessage{
Action: network.Accept,