p2p: exclude self from GetPeers results #6132
Open
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6132 +/- ##
==========================================
+ Coverage 49.25% 51.76% +2.50%
==========================================
Files 644 644
Lines 86521 86524 +3
==========================================
+ Hits 42617 44789 +2172
+ Misses 41040 38862 -2178
- Partials 2864 2873 +9 ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
Oct 17, 2024
cce
previously approved these changes
Jan 7, 2025
gmalouf
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While running DevNet tests I've noticed a node might emit TxSync request to self that does not make any sense.
Fixed by filtering out node's own peerID from peerstore output.
Note, wsnet implementation is not modified because it cannot reliable identify self from DNS (and possible phonebook.json) input.
Test Plan
Added a unit test