Network: Class-based Peer Selector #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erance factor violations, priority and lastCheckedTime.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5937 +/- ##
=======================================
Coverage 55.71% 55.71%
=======================================
Files 487 488 +1
Lines 68048 68103 +55
=======================================
+ Hits 37911 37945 +34
- Misses 27572 27584 +12
- Partials 2565 2574 +9 ☔ View full report in Codecov by Sentry. |
… check violations of tolerance factor during iteration of peer selectors in getNextPeer().
…ll of it's download functionality (implying that failures around catchpoint downloads for a peer from a class put that class at risk of being disabled temporarily).
jasonpaulos
reviewed
Feb 16, 2024
…ises using actual peer selectors and expected ranking behavior.
… connected out, relays, archival nodes.
…d by order of wrappedPeerSelectors at construction.
…resets when all selectors have been disabled.
algorandskiy
approved these changes
Feb 21, 2024
jasonpaulos
approved these changes
Feb 21, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a class-based peer selector for explicitly ranking peer groups based on type and download performance. The intent is to be able to quickly move from one class of peers to the next in cases such as where a client needs older blocks that may only be present on archival nodes.
Test Plan
Introduce new unit tests for class-based peer selector, existing tests should be updated/pass.