Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to display mnemonic discreetly for algokey import and algokey export #5932

Closed
wants to merge 3 commits into from

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Feb 7, 2024

Summary

Similar to #5886

Refer to comment, this pr is for algokey import and algokey export

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 55.68%. Comparing base (e1db9e1) to head (20fe899).
Report is 34 commits behind head on master.

Files Patch % Lines
cmd/algokey/export.go 14.28% 6 Missing ⚠️
cmd/algokey/import.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5932      +/-   ##
==========================================
- Coverage   55.71%   55.68%   -0.03%     
==========================================
  Files         487      487              
  Lines       68048    68060      +12     
==========================================
- Hits        37911    37898      -13     
- Misses      27572    27597      +25     
  Partials     2565     2565              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Halimao
Copy link
Contributor Author

Halimao commented Feb 29, 2024

@gmalouf Hi sir, could u plz help me review this PR, since it's similar to PR #5886 and this new feature won't take effect by default

@Halimao
Copy link
Contributor Author

Halimao commented Apr 4, 2024

@algorandskiy Hi sir, could u plz help me review this pr~

@gmalouf
Copy link
Contributor

gmalouf commented Apr 4, 2024

Hi there,

We've discussed this as a team, and decided not to move forward here. Further we just merged #5974, which reverts #5886.

As part of a review of our external dependencies (in the wake of the xz incident), we decided the sensitivity of this data was not worth the risk inherent in post-processing it with this external library.

Best of luck with your further work.

Algorand Team

@gmalouf gmalouf closed this Apr 4, 2024
@Halimao Halimao deleted the feat/algokey-discreet branch April 5, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants