p2p: rate limit outgoing p2p http connections #5931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
P2PNetwork
to produce rate limiting outgoing HTTP clients. There are some some movements into subpackages to allow bothnetwork
,p2p
,peerstore
to use some utilities/functionality.network/addr
network/phonebook
(to make peerstore's interface compatible with phonebook)network/limitcaller
Had to modify phonebook interface to accept both string and
p2p.peer.AddrInfo
(alternative is to marshalAddrInfo
to bytes, cast and unmarshal but it is kind of the same). Plus, the current peerstore's implementation ofPhonebook
interface uses "host:port" as peerID and works only with "host:port" addresses and not with any kind of p2p addresses so it requires some change anyway. This is a first step.Test Plan
Added a unit test.