-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: http catchpoints support #5924
p2p: http catchpoints support #5924
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5924 +/- ##
===============================================
+ Coverage 55.98% 56.06% +0.07%
===============================================
Files 482 482
Lines 68057 68108 +51
===============================================
+ Hits 38103 38186 +83
+ Misses 27347 27318 -29
+ Partials 2607 2604 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked a few questions, okay with approving after get a response to those.
Summary
P2P HTTP support for ledger service:
GetHTTPRequestConnection
:StreamChainingHost
wrapper forlibp2p.host.Host
allows multiple stream handlers for the same protocol.IDTest Plan
Added unit test for fetcher, service and new p2p stream wrapper.