Network: Like #5906, but for messageFilter, optimize cache mem and speed #5913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't allocate all the maps ahead of time, when we do allocate them,
allocate them fullsize, and use `struct{}` instead of `bool`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5913 +/- ##
==========================================
- Coverage 55.99% 55.99% -0.01%
==========================================
Files 478 478
Lines 67602 67601 -1
==========================================
- Hits 37855 37854 -1
+ Misses 27187 27186 -1
- Partials 2560 2561 +1 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Jan 22, 2024
jasonpaulos
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allocate all the maps ahead of time, when we do allocate them, allocate them fullsize, and use
struct{}instead ofbool.I'm a little unsure how well this is exercised in tests, since
messageFilter_test.gois just a hash benchmark. But I did intentionally do it wrong at first, saw failures, them did it right.First noted by @pao-beep