Config: Archival mode is no longer automatically enabled when netAddress is s…

[gmalouf]

Summary

Archival mode is no longer automatically enabled when netAddress is set in configuration (allowing for non-archival relays). Updated relay profile to reflect more ideal non-archival relay properties (number of catchpoints retained, 20k block history lookback, etc.

Test Plan

Existing tests should pass.

[algorandskiy]

I think test/e2e-go/cli/goal/expect/catchpointCatchupTest.exp needs to set Archival=true and CatchpointFileHistoryLength=1000 explicitly, since with the other test settings older catchpoints get deleted. I had the same issue in my PR when disabled Archival (not sure why, I did not touch the CatchpointFileHistoryLength option).

There are also two tests TestLocal_MergeConfig and TestArchivalIfRelay that explicitly tested the old config options adjustments.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (434dca0) 55.99% compared to head (359a653) 55.95%.

Files	Patch %	Lines
cmd/algocfg/profileCommand.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5904      +/-   ##
==========================================
- Coverage   55.99%   55.95%   -0.04%     
==========================================
  Files         478      478              
  Lines       67588    67589       +1     
==========================================
- Hits        37848    37822      -26     
- Misses      27185    27204      +19     
- Partials     2555     2563       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[onetechnical]

This looks fine, though we should do some archival -> non-archival upgrade testing to observe behavior. This may have some interesting performance characteristics.