Disable ncurses for oksh #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving all builds to a single Docker stage, the shells started to build all in the same machine, causing oksh to be linked against ncurses. Since the build stage is different from the final image, ncurses was missing and causing oksh binaries to fail invokation. This change disables linking against ncurses during build, fixing the issue. Our goal is not to provide interactive shells for personal use, so lacking ncurses still results in a perfectly good oksh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving all builds to a single Docker stage, the shells started to build all in the same machine, causing oksh to be linked against ncurses.
Since the build stage is different from the final image, ncurses was missing and causing oksh binaries to fail invokation.
This change disables linking against ncurses during build, fixing the issue.
Our goal is not to provide interactive shells for personal use, so lacking ncurses still results in a perfectly good oksh.