Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few changes #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a few changes #9

wants to merge 1 commit into from

Conversation

langdon
Copy link

@langdon langdon commented Jul 24, 2017

  • minor text changes in readme
  • removed host-model pass through in vagrantfile as it was causing me problems (unless required these things should not be set and left to the user instead). May want to consider removing the nested flag as well to not block on machines without nested virt. Personally, I would just drop the whole libvirt block as it isn't required. It was in the source to be able to bump the ram up for module development.
  • modified commands to only run the nec. things as root on the user machine, vagrant should be run as a normal user and, for me, it was pretty busted trying to run as root
  • modified vagrantfile to give the generated vm a more sane name
  • modified import_tasks to include to work with f26 version of ansible (wouldn't modularity be great?)

…antfile (unless required these things should not be set and left to the user instead); modified commands to only run the nec. things as root on the user machine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant