-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shelly1 as GarageDoorOpener - actually Garage Door Switch #239
base: master
Are you sure you want to change the base?
Add Shelly1 as GarageDoorOpener - actually Garage Door Switch #239
Conversation
See also #121 |
Is this being merged in the next release or not? |
This currently only works with the Shelly 1 switch input. Don't have a Shelly1 Addon, so unable to try, but think it's easy to adapt. |
Would it help to get you an Addon for testing or is this type of code extension of no interest for you? |
@apartmedia yes that would help me of course and I am happy to spend some time on it. Indeed the current PR has not been merged in into the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MichaelVdheeren! I have a few comments, otherwise LGTM!
@alexryd thanks for the feedback, will run over the requests during the weekend - also will add to the README as part of this pull request. |
👍 |
would this feature give visibility to the external switch add-on state? I use a reed sensor on my garage door, it shows open in the shelly app with the vertical line on the button. it would be great to see the state of the reed sensor through hoobs. |
@MichaelVdheeren Could you manage to work on alexryd request regarding your door opener code? |
Would also like to see this feature merged in |
befc6f2
to
3ee6017
Compare
Should be all done. Know some further improvements I can work on to include the STOPPED state but that needs some more work. |
Hi, is it Possible to make the Shelly1 as type "GarageDoorOpener"? like in Shelly 2.5 ?? |
Can this be merged? Thanks |
would be so great if this could be merged. I created a local repo and merged it with master to test. |
@MichaelVdheeren |
No description provided.