Connection::when_ready Future #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit future type makes implementing executors easier, but is an indepently useful change.
Named future for the when-ready method which skips the use of the `poll_fn` combinator (which becomes un-nameable because of the closure) and replaces it with an explicit struct that impls Future.
alexrudy
force-pushed
the
refactor/when-ready-future
branch
from
243bbcc to
689df9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named future for the when-ready method which skips the use of the
poll_fncombinator (which becomes un-nameable because of the closure) and replaces it with an explicit struct that impls Future.Applied to both the trait, and the PooledConnection type generically (the latter for use in the client service)