Skip to content

Commit

Permalink
Tests for get_orders_for_all_linked_accounts
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexgolec
alexgolec committed May 3, 2024
1 parent d22b13a commit ba8adce
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 81 deletions.
3 changes: 1 addition & 2 deletions schwab/client/base.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,7 @@ def get_orders_for_all_linked_accounts(self,
max_results=None,
from_entered_datetime=None,
to_entered_datetime=None,
status=None,
statuses=None):
status=None):
'''Orders for all linked accounts. Optionally specify a single status on
which to filter.
Expand Down
145 changes: 66 additions & 79 deletions tests/client_test.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ def test_cancel_order_str(self):
self.mock_session.delete.assert_called_once_with(
self.make_url('/trader/v1/accounts/{accountHash}/orders/{orderId}'))


# get_orders_for_account

@patch('schwab.client.base.datetime.datetime', mockdatetime)
Expand Down Expand Up @@ -457,123 +458,109 @@ def test_get_orders_for_account_status_unchecked(self):
})


'''
# get_orders_by_query
# get_orders_for_all_linked_accounts

@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_vanilla(self):
self.client.get_orders_by_query()
def test_get_orders_for_all_linked_accounts_vanilla(self):
self.client.get_orders_for_all_linked_accounts()
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
self.make_url('/trader/v1/orders'), params={
'fromEnteredTime': NOW_DATETIME_MINUS_60_DAYS_ISO,
'toEnteredTime': NOW_DATETIME_ISO
})

@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_max_results(self):
self.client.get_orders_by_query(max_results=100)
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
'toEnteredTime': NOW_DATETIME_ISO,
'maxResults': 100,
})

@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_from_entered_datetime(self):
self.client.get_orders_by_query(from_entered_datetime=EARLIER_DATETIME)
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': EARLIER_ISO,
'toEnteredTime': NOW_DATETIME_ISO,
})
def test_get_orders_for_all_linked_accounts_from_not_datetime(self):
with self.assertRaises(ValueError) as cm:
self.client.get_orders_for_all_linked_accounts(
from_entered_datetime='2020-01-02')
self.assertEqual(
str(cm.exception),
"expected type in (datetime.date, datetime.datetime) for " +
"from_entered_datetime, got 'builtins.str'")

@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_to_entered_datetime(self):
self.client.get_orders_by_query(to_entered_datetime=EARLIER_DATETIME)
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
'toEnteredTime': EARLIER_ISO,
})

@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_status_and_statuses(self):
with self.assertRaises(
ValueError, msg='at most one of status or statuses may be set'):
self.client.get_orders_by_query(
to_entered_datetime=EARLIER_DATETIME,
status='EXPIRED', statuses=[
self.client_class.Order.Status.FILLED,
self.client_class.Order.Status.EXPIRED])
def test_get_orders_for_all_linked_accounts_to_not_datetime(self):
with self.assertRaises(ValueError) as cm:
self.client.get_orders_for_all_linked_accounts(
to_entered_datetime='2020-01-02')
self.assertEqual(
str(cm.exception),
"expected type in (datetime.date, datetime.datetime) for " +
"to_entered_datetime, got 'builtins.str'")


@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_status(self):
self.client.get_orders_by_query(status=self.client_class.Order.Status.FILLED)
def test_get_orders_for_all_linked_accounts_max_results(self):
self.client.get_orders_for_all_linked_accounts(max_results=100)
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
self.make_url('/trader/v1/orders'), params={
'fromEnteredTime': NOW_DATETIME_MINUS_60_DAYS_ISO,
'toEnteredTime': NOW_DATETIME_ISO,
'status': 'FILLED'
'maxResults': 100,
})


@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_status_unchecked(self):
self.client.set_enforce_enums(False)
self.client.get_orders_by_query(status='FILLED')
def test_get_orders_for_all_linked_accounts_from_entered_datetime(self):
self.client.get_orders_for_all_linked_accounts(
from_entered_datetime=datetime.datetime(
year=2024, month=6, day=5, hour=4, minute=3, second=2))
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
self.make_url('/trader/v1/orders'), params={
'fromEnteredTime': '2024-06-05T04:03:02Z',
'toEnteredTime': NOW_DATETIME_ISO,
'status': 'FILLED'
})


@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_statuses(self):
self.client.get_orders_by_query(statuses=[
self.client_class.Order.Status.FILLED,
self.client_class.Order.Status.EXPIRED])
def test_get_orders_for_all_linked_accounts_to_entered_datetime(self):
self.client.get_orders_for_all_linked_accounts(
to_entered_datetime=datetime.datetime(
year=2024, month=6, day=5, hour=4, minute=3, second=2))
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
'toEnteredTime': NOW_DATETIME_ISO,
'status': 'FILLED,EXPIRED'
self.make_url('/trader/v1/orders'), params={
'fromEnteredTime': NOW_DATETIME_MINUS_60_DAYS_ISO,
'toEnteredTime': '2024-06-05T04:03:02Z',
})


@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_statuses_scalar(self):
self.client.get_orders_by_query(statuses=self.client_class.Order.Status.FILLED)
def test_get_orders_for_all_linked_accounts_status(self):
self.client.get_orders_for_all_linked_accounts(
status=self.client_class.Order.Status.FILLED)
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
self.make_url('/trader/v1/orders'), params={
'fromEnteredTime': NOW_DATETIME_MINUS_60_DAYS_ISO,
'toEnteredTime': NOW_DATETIME_ISO,
'status': 'FILLED'
})


@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_for_all_linked_accounts_multiple_statuses(self):
with self.assertRaises(ValueError) as cm:
self.client.get_orders_for_all_linked_accounts(
status=[self.client_class.Order.Status.FILLED,
self.client_class.Order.Status.REJECTED])
self.assertIn(
'expected type "Status", got type "list"',
str(cm.exception))


@patch('schwab.client.base.datetime.datetime', mockdatetime)
def test_get_orders_by_query_statuses_unchecked(self):
def test_get_orders_for_all_linked_accounts_status_unchecked(self):
self.client.set_enforce_enums(False)
self.client.get_orders_by_query(statuses=['FILLED', 'EXPIRED'])
self.client.get_orders_for_all_linked_accounts(status='NOT_A_STATUS')
self.mock_session.get.assert_called_once_with(
self.make_url('/v1/orders'), params={
'fromEnteredTime': MIN_ISO,
self.make_url('/trader/v1/orders'), params={
'fromEnteredTime': NOW_DATETIME_MINUS_60_DAYS_ISO,
'toEnteredTime': NOW_DATETIME_ISO,
'status': 'FILLED,EXPIRED'
'status': 'NOT_A_STATUS'
})

'''

'''
# search_instruments
Expand Down

0 comments on commit ba8adce

Please sign in to comment.