Skip to content

Commit

Permalink
Clarify MSRV intent in contributor docs
Browse files Browse the repository at this point in the history
Currently we support 3 versions of rustc (current, current-1, and
current-2). This is probably too small a window for someone out there on
the internet so this commit adds a clarification with some rationale for
the current policy as well as an olive branch for "please talk to us if
you want a wider window". Basically I wanted to update this to
explicitly declare intent that we're open to reconsidering this policy
as necessary (without actually committing to any alternative policy
yet).
  • Loading branch information
alexcrichton committed Jan 6, 2025
1 parent fc3c868 commit a9dad92
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion docs/contributing-coding-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ $ cargo clippy --workspace --all-targets
Contributors are welcome to enable new lints and send PRs for this. Feel free to
reach out if you're not sure about a lint as well.

### Minimum Supported `rustc` Version
### Minimum Supported `rustc` Version (MSRV)

Wasmtime and Cranelift support the latest three stable releases of Rust. This
means that if the latest version of Rust is 1.72.0 then Wasmtime supports Rust
Expand All @@ -103,6 +103,13 @@ periodically and the general repository does not depend on nightly features.
Updating Wasmtime's MSRV is done by editing the `rust-version` field in the
workspace root's `Cargo.toml`

Note that this policy is subject to change over time (notably it might be
extended to include more rustc versions). Current Wasmtime users don't require a
larger MSRV window to justify the maintenance needed to have a larger window. If
your use case requires a larger MSRV range though please feel free to contact
maintainers to raise your use case (e.g. an issue, in a Wasmtime meeting, on
Zulip, etc).

### Dependencies of Wasmtime

Wasmtime and Cranelift have a higher threshold than default for adding
Expand Down

0 comments on commit a9dad92

Please sign in to comment.