Reject password inputs looking like raw bcrypt #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a password arrives in the authorization header as a string looking like bcrypt (according to standard Modular Crypt Format) instead of normal-looking plain-text, then reject the authentication. This is to avoid being able to pass the crypted version of the password, in case it was leaked.
quackzar
approved these changes
Nov 9, 2023
test.sh
Outdated
|
|
||
| test=$( | ||
| cat <<'EOF' | node ./index.js http-basic-auth --realm='"node-red"' --username='"test"' --password='"$2y$10$5TSZDldoJ7MxDZdtK/SG2O3cwORqLDhHabYlKX9OsM.W/Z/oLwKW6"' | ||
| {"req":{"headers":{"authorization":"Basic dGVzdDokMnkkMTAkNVRTWkRsZG9KN014RFpkdEsvU0cyTzNjd09ScUxEaEhhYllsS1g5T3NNLlcvWi9vTHdLVzY="}}} |
There was a problem hiding this comment.
It might be less opaque if the test input isn't hardcoded in base64 but just calls the base64 command as a subshell or using a variable.
There was a problem hiding this comment.
Good idea. Here you are c6842f5
| * Is the password matching the Modular Crypt Format of bcrypt | ||
| */ | ||
| function isBcryptMcf(hash) { | ||
| return (typeof hash === 'string') && hash.match(/^\$2[abxy]?\$/); |
There was a problem hiding this comment.
While unlikely, we now reject some passwords if they match that regex. While unlikely, it might be an issue for some esoteric password generators.
There was a problem hiding this comment.
Yes indeed. There is the same behaviour in e.g. Apache htpasswd approach, which I try to be compatible with
There was a problem hiding this comment.
That would probably be the better solution then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a password arrives in the authorization header as a string looking like bcrypt (according to standard Modular Crypt Format) instead of normal-looking plain-text, then reject the authentication.
This is to avoid being able to pass the crypted version of the password, in case it was leaked.