More readable options.txt #399
Conversation
Now not horrible inefficient
|
Updated to optimize saving code because it was very inefficient and concatenation-heavy |
I broke hat stacking but I unbroke it
There was a problem hiding this comment.
Updated to LÖVE 11, and resolved the criticism of my earlier review.
I have to say there's a lot of options for how to improve the behemoth that is config saving and loading, but I don't really think a migration to string formatting is one of them. To me it feels even less readable than before and that's quite saying something. It strikes me as an especially premature optimization, as these functions realistically will only take a few milliseconds at most to run and are hardly ever called, and I'm not especially convinced that string formatting would even be all that much faster in a context where all the args are going to be computed regardless. I'd personally prefer if this was reverted back to just a simple \n addition, or upgraded to something like a proper table where keys are set then converted to text at the end (like is done for some of the individual keys).
|
Yeah the main change was to make it more readable, the changes to the saving was mostly because I was bored lol. Saving the config can take a tangible amount of time if you accidentally travel to a very high numbered world and it saves a few hundred or thousand reachedworlds entries, but I think that's a separate problem |
Adds line breaks to options.txt to make it humanly readable, still backward compatible