feat: parameter to add a space under the calendar #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you use the
markerMargin
parameter in order to add some top margin, the rendering of the Marker can be cropped at the bottom of the Calendar.The proposed solution would be to increase the
rowHeight
parameter in order to correctly handle the display of the markers. Sadly, this solution won't fit every needs.I ended up with the solution of adding a new parameter that I called
bottomSpace
(could have beenbottomMargin
, but I thought that this name was misleading) which job is to add some more space in theAnimatedContainer
rendering the Calendar, and thus allowing to correctly draw the Markers.There might be a sexier solution to this issue, but it'd ask a lot more work and brain juice, alongside with a lot more of refactoring. With this update, it won't break anything to the current users