Akka.Actor: Added built-in IntentionalRestart message to test actor restart behaviors
#7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jan 31, 2025
| @@ -1264,6 +1264,15 @@ namespace Akka.Actor | |||
| public Akka.Actor.IActorRef Watch(Akka.Actor.IActorRef subject) { } | |||
| public Akka.Actor.IActorRef WatchWith(Akka.Actor.IActorRef subject, object message) { } | |||
| } | |||
| public sealed class IntentionalActorRestartException : Akka.Actor.AkkaException | |||
There was a problem hiding this comment.
Added a new IntentionalActorRestartException and an IntentionalRestart auto-received message. I hope the naming makes it obvious why these exist.
There was a problem hiding this comment.
misc-serializer support for IntentionalRestart
| TestActor.Tell(mess); | ||
|
|
||
| // can't relay the Restart back because that will blow up the TestActor | ||
| if (mess is not IntentionalRestart) |
There was a problem hiding this comment.
Can't reply back with the IntentionalRestart message because it will crash the TestActor.
| @@ -132,27 +132,38 @@ protected internal virtual void AutoReceiveMessage(Envelope envelope) | |||
|
|
|||
| switch (message) | |||
| { | |||
| case ActorSelectionMessage selectionMessage: | |||
There was a problem hiding this comment.
Re-organized the switch order for performance reasons - with the most frequent messages appearing first for short-circuiting reasons.
| break; | ||
| case Identify identify: | ||
| HandleIdentity(identify); | ||
| case Akka.Actor.IntentionalRestart: |
There was a problem hiding this comment.
Added restart handling here - it just throws an IntentionalActorRestartException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #7492
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):