Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Akka.Analyzers install canary #103

Draft
wants to merge 18 commits into
base: dev
Choose a base branch
from

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Jul 26, 2024

Changes

Should be able to reproduce akkadotnet/akka.net#7307

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb
Copy link
Member Author

Welp, this is why the Canary is dubiously passing:

error: Error while adding package 'Akka.Analyzers' to project 'D:\a\akka.analyzers\akka.analyzers\test\Akka.Analyzers.NetFxInstallCanary\Akka.Analyzers.NetFxInstallCanary.csproj'. The project does not support adding package references through the add package command.

We probably need to re-tool this to use the powershell Package-Install commands

@Aaronontheweb Aaronontheweb marked this pull request as draft September 18, 2024 14:17
run: |
# Install Akka.Analyzers package
dotnet add package Akka.Analyzers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the issue - we need to replace these dotnet SDK calls with pre-SDK ones, such as using the NuGet PowerShell scripts. That might be a pain in the butt, but it's necessary if we want to support #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant