fix: Fix Jellyseerr Avatar Loading Issue

[TyxTang]

Category

Bugfix

Overview

Jellyseerr version 2.0.1 changed rewrite avatarproxy and CachedImage
Request address changed to add /avatarproxy
This prevented the correct user avatar from being requested in the media request component.
Adapting to use older versions of Jellyseerr

Issue

Related PR

[github-actions]

Hi 👋. Thank you for making your first contribution to Homarr. Please ensure that you've completed all the points in the TODO checklist. We'll review your changes shortly.

[manuel-rw]

I dislike sending a retry request to a differnt URL.
Since this change was implemeted after a specific version, we should instead fetch the version and use the other URL if this version is above a specific threshold.

[TyxTang]

I dislike sending a retry request to a differnt URL. Since this change was implemeted after a specific version, we should instead fetch the version and use the other URL if this version is above a specific threshold.

Yes I agree with you, I'm checking the Jellyseerr API docs to implement getting the version number.

[manuel-rw]

I dislike sending a retry request to a differnt URL. Since this change was implemeted after a specific version, we should instead fetch the version and use the other URL if this version is above a specific threshold.

Yes I agree with you, I'm checking the Jellyseerr API docs to implement getting the version number.

Thank you, please tag me again for another review once you implemented my comment

[TyxTang]

I tried using the version comparison method, requesting /api/v1/status to get the version number,
and then comparing it to v2.0.1 was used to determine if it was the version before the change or the version after the change.

Met succes getest op zowel Jellyseerr v1.9.3 als v2.0.1

[TyxTang]

There is no way to perfectly reproduce the problem of version fetching errors, so I chose to set the default value of shouldUseV2ApiCall to false anyway and added exception detection.

I've also tested that the program works fine when Jellyseerr connectivity is fine but api/v1/status is not available.

Since I'm still in the learning stage, this is the optimal solution I came up with, if there is a better way, please correct me!

[SeDemal]

This looks like a lot of pain for not much.
Can't you just produce both links and set them as src and fallbackSrc in an Image element?

[TyxTang]

This looks like a lot of pain for not much. Can't you just produce both links and set the new one as a fallback in the Image element?

It seems I don't have a good way to detect that one of the links is unavailable
Which brings us back to testing connectivity.
Maybe it could be like jumping to a preset image after not being able to get an avatar in the first place.

[SeDemal]

Don't test availability and don't test connectivity then.
We can already determine that the Avatar is capable of "detecting" that the image doesn't work since it's using a fallback image.
Meaning that if we just set an Image element with one link as src, then you put the new link as fallbackSrc, the frontend will do the detection for you. Now I'm guessing you can put said Image element as a child of the Avatar, or replace the avatar and just shape the Image like the Avatar.
We don't need to know what version people are running.

Also, if people are updating Homarr, chances are they are updating other containers as well, so why are we even trying to have multiple options? Unless jellyseerr is in a beta (like we had with sonarr a while back iirc), then just update the link.

[TyxTang]

Don't test availability and don't test connectivity then. We can already determine that the Avatar is capable of "detecting" that the image doesn't work since it's using a fallback image. Meaning that if we just set an Image element with one link as src, then you put the new link as fallbackSrc, the frontend will do the detection for you. Now I'm guessing you can put said Image element as a child of the Avatar, or replace the avatar and just shape the Image like the Avatar. We don't need to know what version people are running.

Also, if people are updating Homarr, chances are they are updating other containers as well, so why are we even trying to have multiple options? Unless jellyseerr is in a beta (like we had with sonarr a while back iirc), then just update the link.

This method is great and I'm testing it to make sure it works!

[SeDemal]

I just got a report on discord that Jellyseerr's new update fixed it all already, I'm guessing this was actually not done on purpose.
From what I can see, it was intended for both urls to keep working, so this implementation is still a good idea.

[SeDemal]

I'll be honest, at first I was actually suggesting to only use the image element and remove the Avatar completely, but I think it's actually a good idea to keep it as a wrapper. Great job there.

The only thing left would be to remove the duplication of the functions, since that defeats the purpose of functions, but other than that it looks good to me.

Thanks for your patience and your contribution :)

[SeDemal]

lgtm