Skip to content

Commit

Permalink
Merge pull request kubernetes#130316 from googs1025/flake/TestSchedul…
Browse files Browse the repository at this point in the history
…erGuaranteeNonNilNodeInSchedulingCycle

flake(scheduler): fix allWaitSchedulingPods data race failed
  • Loading branch information
k8s-ci-robot authored Feb 21, 2025
2 parents 97c7a16 + 04b048d commit de7708f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/scheduler/schedule_one_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -638,17 +638,22 @@ func TestSchedulerGuaranteeNonNilNodeInSchedulingCycle(t *testing.T) {
for i := 0; i < waitSchedulingPodNumber; i++ {
allWaitSchedulingPods.Insert(fmt.Sprintf("pod%d", i))
}
var wg sync.WaitGroup
var (
wg sync.WaitGroup
mu sync.Mutex
)
wg.Add(waitSchedulingPodNumber)
stopFn, err := broadcaster.StartEventWatcher(func(obj runtime.Object) {
e, ok := obj.(*eventsv1.Event)
if !ok || (e.Reason != "Scheduled" && e.Reason != "FailedScheduling") {
return
}
mu.Lock()
if allWaitSchedulingPods.Has(e.Regarding.Name) {
wg.Done()
allWaitSchedulingPods.Delete(e.Regarding.Name)
}
mu.Unlock()
})
if err != nil {
t.Fatal(err)
Expand Down

0 comments on commit de7708f

Please sign in to comment.