internal: Remove Enzyme from visx #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 16, 2024 19:28
williaster
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Thanks @chazcb , this is awesome 👏 🤖
Noticed some minor problems I can fix.
Comment on lines
+34
to
+37
| // Verify the path connects the correct points | ||
| const dAttribute = path?.getAttribute('d') || ''; | ||
| expect(dAttribute).toContain('M100,100'); // Should start at x,y | ||
| expect(dAttribute).toContain('150,150'); // Should end at x+dx,y+dy |
There was a problem hiding this comment.
improved the tests here! 🤖 🎉
williaster
reviewed
Dec 17, 2024
| @@ -40,8 +40,5 @@ | |||
| }, | |||
| "publishConfig": { | |||
| "access": "public" | |||
| }, | |||
| "devDependencies": { | |||
| "@testing-library/react-hooks": "^8.0.0" | |||
There was a problem hiding this comment.
left over from #1890, hoping this fixes the failing @visx/react-spring hooks test suite
|
This is really amazing 🎉 If this was done using LLM this might warrant a blog post or so somewhere... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Enzyme with RTL in prep for React 19 support.
🏠 Internal
jest.mockusage