WIP

ai-for-java · Oct 15, 2024 · ea69339 · ea69339
1 parent e20ed91
commit ea69339
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/test/java/dev/ai4j/openai4j/chat/ChatCompletionTest.java b/src/test/java/dev/ai4j/openai4j/chat/ChatCompletionTest.java
@@ -609,7 +609,7 @@ void testStrictJsonResponseFormat(ChatCompletionModel model) {
 
 
     @Test
-    void testJsonResponseFormatWithRecursion() {
+    void testJsonResponseFormatWithExplicitRecursion() {
 
         // given
         boolean strict = true;
@@ -620,7 +620,9 @@ void testJsonResponseFormatWithRecursion() {
                         .properties(new LinkedHashMap<String, JsonSchemaElement>() {{
                             put("name", JsonStringSchema.builder().build());
                             put("children", JsonArraySchema.builder()
-                                    .items(JsonReferenceSchema.builder().reference("#/$defs/person").build())
+                                    .items(JsonReferenceSchema.builder()
+                                            .reference("#/$defs/person")
+                                            .build())
                                     .build());
                         }})
                         .required(asList("name", "children"))
@@ -663,9 +665,8 @@ void testJsonResponseFormatWithRecursion() {
                         "]}");
     }
 
-    // TODO remove?
     @Test
-    void testJsonResponseFormatWithRecursion2() {
+    void testJsonResponseFormatWithRootRecursion() {
 
         // given
         boolean strict = true;
@@ -676,7 +677,9 @@ void testJsonResponseFormatWithRecursion2() {
                         .properties(new LinkedHashMap<String, JsonSchemaElement>() {{
                             put("name", JsonStringSchema.builder().build());
                             put("children", JsonArraySchema.builder()
-                                    .items(JsonReferenceSchema.builder().reference("#").build())
+                                    .items(JsonReferenceSchema.builder()
+                                            .reference("#") // root recursion
+                                            .build())
                                     .build());
                         }})
                         .required(asList("name", "children"))