Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devkit only uses a small % of ocamlnet and having to maintain this package with recent versions of OCaml is adding some maintenance burden.
This PR vendors just the necessary parts of ocamlnet to keep devkit interface the same. The subset of ocamlnet is placed into an
ocamlnet_lite
library.The largest parts of the vendored lib areEdit: this has been simplified in 17e7d39 and e223ac1.Netconversion
(by far) andNetencoding
. I think there are ways to simplify more, but I took an attempt at it and I ran into some issues due to the wayEnc_subset
is used inencode_poly
Another potential cleanup is to remove
tstring_kind
, as onlyString_kind
is used. I already removed the memory branch, as it allowed to not bring in more modules, but left both string and bytes kinds:devkit/ocamlnet_lite/netstring_tstring.ml
Lines 3 to 5 in 380fa87
TODO