Support OpenSSL 3 & JWT 2.2 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatibility with JWT 2.0
Updates the Zendesk SSO article linked in the README which is currently broken.
Since JWT 2.0 the signature verification checks that the algorithm passed to `encode` is the same as the `alg` value in the token. If you support multiple algorithms you can pass an `algorithms: []` option to the `JWT.decode` call. This updates the omniauth strategy to allow us passing multiple options to the `decode` call to support multiple algorithms (and not just HS256). * jwt/ruby-jwt#184
Compatibility with JWT 2.2
- 🔥 Remove Ruby 2.5 & 2.6 from build matrix
🐛 Fix handling of algorithm vs. algorithms
- OpenSSL::PKey::RSA - RS256 - RS384 - RS512 - OpenSSL::PKey::EC - ES256 - ES384 - ES512
✨ Support OpenSSL (ripped from gitlabhq fork)
…v2 (#6) * 🐛 Fix compatibility with omniauth v1 & v2, rack v2 & v3, rack-session v1 & v2 - Ref: rack/rack-session#26 * 👷 Add ancient build for Ruby 2.2 & 2.3 * 💚 Better handling of ancient ruby scenario * 💚 Ancient ruby support * ✨ Support Ruby 2.2 & 2.3
|
I've released these changes as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from Discourse and GitLabHQ forks
Ref: mbleigh#8