Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLModel Code generation fixes #358

Merged
merged 15 commits into from
Jan 23, 2025
Merged

SQLModel Code generation fixes #358

merged 15 commits into from
Jan 23, 2025

Conversation

sheinbergon
Copy link
Collaborator

Fixes 302

@sheinbergon sheinbergon mentioned this pull request Jan 9, 2025
Closed
2 tasks
@sheinbergon
Copy link
Collaborator Author

sheinbergon commented Jan 9, 2025 •
edited
Loading

@agronholm notice this PR also completely removes mapped_column for SQLModel , which according to fastapi/sqlmodel#970 is still broken. I'm guessing SQLModel broke when you introduced that to the codebase. All tests are now passing 🥳 , and I believe this takes care of some open issues/prs as well

@sheinbergon sheinbergon mentioned this pull request Jan 9, 2025
Closed
@sheinbergon sheinbergon requested a review from agronholm January 9, 2025 22:29
@sheinbergon
Copy link
Collaborator Author

@agronholm I also tested generated sqlmodel with both orm functionalities (get,get_one,add) as well as well SQL queries (select(...).where()), and both seem to function properly

agronholm
agronholm requested changes Jan 11, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
src/sqlacodegen/generators.py Outdated Show resolved Hide resolved
src/sqlacodegen/generators.py Outdated Show resolved Hide resolved
@sheinbergon sheinbergon requested a review from agronholm January 23, 2025 20:53
@sheinbergon
Copy link
Collaborator Author

@agronholm all PR comments have been fixed according to your guidance, and conversations resolved. Hoping we can move forwrad

agronholm
agronholm requested changes Jan 23, 2025
View reviewed changes
src/sqlacodegen/cli.py Outdated Show resolved Hide resolved
@agronholm agronholm merged commit a7e38e6 into agronholm:master Jan 23, 2025
7 checks passed
@agronholm
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motey motey motey left review comments

@agronholm agronholm agronholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLModel codegen produces syntax errors
3 participants
@sheinbergon @agronholm @motey