Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EXCLUSIONS config value #120

Merged
merged 10 commits into from
May 7, 2024
Merged

Implement EXCLUSIONS config value #120

merged 10 commits into from
May 7, 2024

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented May 3, 2024

No description provided.

@stdavis stdavis force-pushed the feat/exclusions branch from d8987ab to 553977b Compare May 3, 2024 17:10
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 17 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@45007c8). Click here to learn what that means.

Files Patch % Lines
src/sweeper/__main__.py 0.00% 9 Missing ⚠️
src/sweeper/address_parser.py 89.74% 2 Missing and 2 partials ⚠️
src/sweeper/config.py 66.66% 1 Missing ⚠️
src/sweeper/sweepers/duplicates.py 0.00% 1 Missing ⚠️
src/sweeper/sweepers/empties.py 0.00% 1 Missing ⚠️
src/sweeper/sweepers/invalids.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage        ?   22.57%           
=======================================
  Files           ?       13           
  Lines           ?      753           
  Branches        ?      145           
=======================================
  Hits            ?      170           
  Misses          ?      578           
  Partials        ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The built in list feature class filtering is for including not excluding right? If that's the case this solution seems great.

@stdavis
Copy link
Member Author

stdavis commented May 6, 2024

The built in list feature class filtering is for including not excluding right?

Yes, the arcpy.ListFeatureClasses() accepts a wild_card parameter. Otherwise, that would have been handy for sure.

@stdavis
Copy link
Member Author

stdavis commented May 6, 2024

I wasn't sure if your last comment indicated that you had reviewed the code yet. So I added some work that I did this morning to this PR.

@stdavis stdavis merged commit 79c6f0f into main May 7, 2024
4 checks passed
@stdavis stdavis deleted the feat/exclusions branch May 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants