Improving integer parsing for url parameters #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't merge this PR since it also introduces an inefficient change to caching - but I've applied your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the id parameter is passed into the
[ux_cv_api4_get]as a string, and in this case theis_intcheck fails, making it impossible to retrieve a specific result.The new check uses the
FILTER_VALIDATE_INTfilter, which will correctly categorize integer strings, but can falsely validate some decimal strings as integers.This one is probably an improvement, as it covers all of the common cases (providing an integer or providing a word), but there might be a more consistent way of validating integers and integer strings.