forked from jessfraz/dockfmt
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from jessfraz:master #4
Open
pull
wants to merge
18
commits into
agflow:master
Choose a base branch
from
jessfraz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow a user to parse the stages from a dockerfile. It interpolates a stage name if none is specified.
* feat: allow outputting the workdir(s) for one or more Dockerfiles This command is useful in inspection of Dockerfiles, and can be used to intelligently push/pull built files from a docker image. It also allows disabling of ranking, such that the the workdirs are output in order of appearance. For instance, if a build tool expects to pull a config file from a container and has access to the respective Dockerfile, it can do something like: ```shell WORKDIR=$(dockfmt workdir --no-rank --skip-header path/to/Dockerfile | tail -n1) [[ -z "$WORKDIR" ]] && WORKDIR="/app" docker cp "container-name:$WORKDIR/nginx.conf.template" nginx.conf || true ``` In this way, we can pull a file from a container at the best path possible - either a specified WORKDIR or a sane default. * fix: correct lint errors * chore: drop skip-header This should be in a separate PR anyhow.
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
* Refactor forFile() to pass *os.File * Refactor forFile() to extract forFile1() * Read from stdin if no dockerfiles given * Use strings.EqualFold() Suggested by static checker * Update usage messages for stdin support
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )