Move inline JS/CSS to files #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FestplattenSchnitzel
force-pushed
the
move_CSS/JS_to_files
branch
from
ec8a60a to
3a4246f
Compare
|
I don't understand the commit message in |
The repository for documents, documents_restricted the news, the (flat) pages etc. |
|
Ah, nevermind. I forgot to translate „content“ to „sipa-content.git repo“ in my head. Of course I know that. Thanks for clarifying. |
FestplattenSchnitzel
force-pushed
the
move_CSS/JS_to_files
branch
3 times, most recently
from
00b0a97 to
cc8d4d8
Compare
lukasjuhrich
force-pushed
the
move_CSS/JS_to_files
branch
from
4ee6f23 to
74201bd
Compare
moving css to the css file moved some js to the js file Problem: some js code need to be rendered by jinja to get the unsupported dorms #453
* The required leaflet* files are now included in the 'content' repository. * raphael.2.1.0.min.js was seemingly used for the traffic limit gauge in the past.
FestplattenSchnitzel
force-pushed
the
move_CSS/JS_to_files
branch
from
74201bd to
6e8d036
Compare
|
@lukasjuhrich it seems you forgot to add the changes in |
lukasjuhrich
force-pushed
the
move_CSS/JS_to_files
branch
from
5b9e04b to
fe116cc
Compare
This sets a hard-coded `script_src` and `style_src` CSP that is only returned in the usersuite index, which is the only location where we use `pygal`. This allows us to forbid un-tagged inline scripts and styles via CSP. `flask.g` is used because we (unfortunately) render the traffic graph indirectly via global jinja callable instead of passing it directly to the template as an argument.
lukasjuhrich
force-pushed
the
move_CSS/JS_to_files
branch
from
4567893 to
4555372
Compare
lukasjuhrich
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developCloses #453 .