add test that generated json from autoyast xml is valid

.github/workflows/ci-service.yml

@@ -86,6 +86,7 @@ jobs:
         yast2-proxy
         yast2-storage-ng
         yast2-users
+        python3-jsonschema
 
     - name: Install RubyGems dependencies
       run: bundle config set --local with 'development' && bundle install

service/lib/agama/autoyast/converter.rb

@@ -63,7 +63,7 @@ def to_agama(dir)
         FileUtils.mkdir_p(path)
         import_yast
         profile = read_profile
-        File.write(path.join("autoinst.json"), export_profile(profile).to_json)
+        File.write(path.join("autoinst.json"), JSON.pretty_generate(export_profile(profile)))
       end
 
     private

service/lib/agama/autoyast/l10n_reader.rb

@@ -37,12 +37,12 @@ def initialize(profile)
       #
       # If there is no l10n information, it returns an empty hash.
       #
-      # @return [Hash] Agama "l10n" section
+      # @return [Hash] Agama "localization" section
       def read
         l10n = keyboard
           .merge(languages)
           .merge(timezone)
-        l10n.empty? ? {} : { "l10n" => l10n }
+        l10n.empty? ? {} : { "localization" => l10n }
       end
 
     private

service/lib/agama/autoyast/scripts_reader.rb

@@ -44,6 +44,7 @@ class ScriptsReader
       # @param profile [ProfileHash] AutoYaST profile
       def initialize(profile)
         @profile = profile
+        @anonymous_counter = 0
       end
 
       # Returns a hash that corresponds to Agama "scripts" section.
@@ -100,10 +101,10 @@ def read_init_scripts
       # @param section [Hash] AutoYaST script section
       def read_script(section)
         script = {
-          "name" => section["file_name"]
+          "name" => section["filename"] || "annonymous#{@anonymous_counter += 1}"
         }
 
-        if section["location"]
+        if section["location"] && !section["location"].empty?
           script["url"] = section["location"]
         elsif section["source"]
           script["body"] = section["source"]

service/test/agama/autoyast/converter_test.rb

@@ -40,8 +40,9 @@
   end
   let(:xml_valid?) { true }
   let(:xml_errors) { [] }
+  let(:result_path) { File.join(workdir, "autoinst.json") }
   let(:result) do
-    content = File.read(File.join(workdir, "autoinst.json"))
+    content = File.read(result_path)
     JSON.parse(content)
   end
   let(:storage_manager) do
@@ -109,7 +110,7 @@
 
       it "evaluates the ERB code" do
         subject.to_agama(workdir)
-        expect(result["l10n"]).to include(
+        expect(result["localization"]).to include(
           "languages" => ["en_US.UTF-8", "es_ES.UTF-8"]
         )
       end
@@ -157,9 +158,9 @@
       end
     end
 
-    it "exports l10n settings" do
+    it "exports localization settings" do
       subject.to_agama(workdir)
-      expect(result["l10n"]).to include(
+      expect(result["localization"]).to include(
         "languages" => ["en_US.UTF-8"],
         "timezone"  => "Atlantic/Canary",
         "keyboard"  => "us"
@@ -177,4 +178,29 @@
       subject.to_agama(workdir)
     end
   end
+
+  context "for cloned profile" do
+    let(:profile_name) { "cloned.xml" }
+
+    it "generate json according to schema" do
+      # sadly rubygem-json-schema cannot be used due to too old supported format
+      if !system("which jsonschema")
+        pending "can run only if python3-jsonschema is installed"
+        break
+      end
+
+      subject.to_agama(workdir)
+
+      schema = File.expand_path(
+        "../../../../rust/agama-lib/share/profile.schema.json",
+        __dir__
+      )
+
+      # filter out deprecation warning as check-jsonschema is not packaged for TW yet
+      result = `jsonschema -i '#{result_path}' '#{schema}' 2>&1 | \
+        grep -v 'DeprecationWarning' | \
+        grep -v 'from jsonschema.cli import main'`
+      expect(result).to eq ""
+    end
+  end
 end

service/test/agama/autoyast/l10n_reader_test.rb

@@ -30,6 +30,8 @@
     {}
   end
 
+  let(:l10n) { subject.read["localization"] }
+
   subject do
     described_class.new(Yast::ProfileHash.new(profile))
   end
@@ -49,7 +51,6 @@
       end
 
       it "includes a 'keyboard' key with its value" do
-        l10n = subject.read["l10n"]
         expect(l10n["keyboard"]).to eq("us")
       end
     end
@@ -65,7 +66,6 @@
       end
 
       it "includes a 'languages' key with all the languages" do
-        l10n = subject.read["l10n"]
         expect(l10n["languages"]).to eq(["en_US.UTF-8", "es_ES.UTF-8", "cs_CZ.UTF-8"])
       end
 
@@ -80,7 +80,6 @@
         end
 
         it "uses the UTF-8 encoding" do
-          l10n = subject.read["l10n"]
           expect(l10n["languages"]).to eq(["en_US.UTF-8", "es_ES.UTF-8"])
         end
       end
@@ -92,7 +91,6 @@
       end
 
       it "includes a 'keyboard' key with its value" do
-        l10n = subject.read["l10n"]
         expect(l10n["timezone"]).to eq("Europe/Berlin")
       end
     end

service/test/agama/autoyast/scripts_reader_test.rb

@@ -32,8 +32,8 @@
 
   context "when the script definition includes the sources" do
     let(:script) do
-      { "file_name" => "script.sh",
-        "location"  => "https://example.com/script.sh" }
+      { "filename" => "script.sh",
+        "location" => "https://example.com/script.sh" }
     end
 
     it "sets the \"url\" to the \"location\"" do
@@ -45,8 +45,8 @@
   context "when the script definition specifies a location" do
     let(:script) do
       {
-        "file_name" => "script.sh",
-        "source"    => "#!/bin/bash\necho 'Hello World!'"
+        "filename" => "script.sh",
+        "source"   => "#!/bin/bash\necho 'Hello World!'"
       }
     end
 
@@ -77,9 +77,9 @@
       it_behaves_like "a script reader", "chroot-scripts", "post"
 
       let(:chroot_script) do
-        { "file_name" => "test.sh",
-          "chrooted"  => true,
-          "source"    => "#!/bin/bash\necho 'Hello World!'" }
+        { "filename" => "test.sh",
+          "chrooted" => true,
+          "source"   => "#!/bin/bash\necho 'Hello World!'" }
       end
 
       let(:profile) do
@@ -92,8 +92,8 @@
 
       context "when the \"chrooted\" option is not set" do
         let(:chroot_script) do
-          { "file_name" => "test.sh",
-            "source"    => "#!/bin/bash\necho 'Hello World!'" }
+          { "filename" => "test.sh",
+            "source"   => "#!/bin/bash\necho 'Hello World!'" }
         end
 
         it "sets the \"chroot\" option to false" do