Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax versions of rubygems and comment out ostruct with reason #1917

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

jreidinger
Copy link
Contributor

Problem

SLFO using ruby3.2 and agama gemspec specifies versions from ruby3.4 which are too high.

Solution

Relax versions as agama does not have problem to run with ruby3.2.
Tricky part is ostruct as it is not provided by ruby3.2 as gem, but as it will be removed after 3.4 lets just comment it out and solve it when need arise ( SLFO should update soon ruby version ).

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12836563806

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.961%

Totals Coverage Status
Change from base Build 12816868990: 0.0%
Covered Lines: 17174
Relevant Lines: 24202

💛 - Coveralls

@jreidinger jreidinger merged commit 88d1f1e into master Jan 17, 2025
6 checks passed
@jreidinger jreidinger deleted the relax_dependencies branch January 17, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants