Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async package at 1.5.2 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickhpan
Copy link

To avoid breaking change to async.whilst. In 1.5.2 and earlier, the first function of async.whilst returns true while the second function is to be called, but in later version of async the function itself takes a callback as argument and calls it to determine whether to continue to the second function.

To avoid breaking change to `async.whilst`. In 1.5.2 and earlier, the first function of `async.whilst` returns `true` while the second function is to be called, but in later version of `async` the function itself takes a callback as argument and calls it to determine whether to continue to the second function.
@patrickhpan
Copy link
Author

function() { return to_bind.length > 0; },

In the current version (as of May 2021) of async, the first function takes a callback as argument (see docs). In 1.5.2, returning a boolean is the expected behavior. The result of using a modern version of async is that the second callback will never be called, preventing the ports from ever being bound.

This should fix the issue in babelpod here: afaden/babelpod#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant