Merge pull request canjs#580 from simpleTechs/can-value-no-undefined

can-value shows "undefined" if bound to undefined value
afaden · Dec 3, 2013 · fb0fca6 · fb0fca6
2 parents 3c4c637 + fdd650c
commit fb0fca6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/view/bindings/bindings.js b/view/bindings/bindings.js
@@ -162,7 +162,8 @@ steal("can/util","can/view/mustache", "can/control", function(can){
 		},
 		"{value} change": "set",
 		set: function(){
-			this.element[0].value = this.options.value()
+			var val = this.options.value();
+			this.element[0].value = (typeof val === 'undefined' ? '' : val);
 		},
 		"change": function(){
 			this.options.value(this.element[0].value)

diff --git a/view/bindings/bindings_test.js b/view/bindings/bindings_test.js
@@ -43,7 +43,7 @@
 
 		var template = can.view.mustache("<input can-value='age'/>")
 
-		var map = new can.Map({age: "30"})
+		var map = new can.Map()
 
 		var frag = template( map )
 
@@ -52,7 +52,11 @@
 		ta.appendChild(frag);
 
 		var input = ta.getElementsByTagName("input")[0];
-		equal(input.value, "30", "input value set correctly")
+		equal(input.value, "", "input value set correctly if key does not exist in map");
+
+		map.attr("age", "30");
+
+		equal(input.value, "30", "input value set correctly");
 
 		map.attr("age","31");