Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants in IdExtensions.IsSnowflake() #9

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Use constants in IdExtensions.IsSnowflake() #9

merged 3 commits into from
Feb 20, 2024

Conversation

haruki-taka8
Copy link
Contributor

Closes #8

@haruki-taka8
Expose constants to assembly
9e250b3 
Extension methods can use these values instead of hard-coded values
@haruki-taka8
Use constants from class Id instead of magic numbers
43edeb0
aevitas
aevitas requested changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@aevitas aevitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the extra newline and merge in the master branch? I've added a simple CI build so we should see green tests in the PR as well.

Thanks a lot for submitting this!

src/FlakeId/Extensions/IdExtensions.cs Outdated Show resolved Hide resolved
aevitas
aevitas approved these changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@aevitas aevitas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing. 👍

@aevitas aevitas merged commit 9192b62 into aevitas:master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aevitas aevitas aevitas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove magic numbers in IdExtensions.IsSnowflake()
2 participants
@haruki-taka8 @aevitas