Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore browser's intro page #1584

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Restore browser's intro page #1584

merged 5 commits into from
Feb 18, 2025

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Feb 15, 2025

This PR is supported by the Æternity Foundation

It deprecates https://github.com/aeternity/aepp-base-home-page
reverts changes made in #1352 and partially 60296ef

A separate home page was needed to satisfy AppStore's requirements. But as I see, Superhero Wallet has a similar interface integrated into the app and they didn't get rejected so Base aepp can do the same.

Also, an integrated home page is need to update sdk because the sdk needs to know when an aepp is opened.

https://developer.mozilla.org/en-US/docs/Web/API/Window/devicePixelRatio

@davidyuk davidyuk added this to the v1.2.1 milestone Feb 15, 2025
@davidyuk davidyuk force-pushed the restore-browser-intro branch from b30957e to 5406d48 Compare February 16, 2025 09:57
@davidyuk davidyuk force-pushed the restore-browser-intro branch 2 times, most recently from 651b558 to 2ee56be Compare February 16, 2025 10:27
@davidyuk davidyuk force-pushed the restore-browser-intro branch 2 times, most recently from e79fdbf to 62ccd0b Compare February 16, 2025 10:46
@davidyuk davidyuk force-pushed the restore-browser-intro branch 2 times, most recently from add56a2 to 322b2c4 Compare February 16, 2025 11:10
@davidyuk davidyuk merged commit 8fb9fe3 into develop Feb 18, 2025
5 of 6 checks passed
@davidyuk davidyuk deleted the restore-browser-intro branch February 18, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant