Update to sdk@13 partially #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
feature/sdk-13-partially
branch
from
5d5cb29 to
37f29a8
Compare
|
Deployed to https://pr-1497-aepp-base.stg.aepps.com |
davidyuk
commented
May 17, 2023
.github/workflows/test.yml
Outdated
| @@ -3,24 +3,21 @@ on: [pull_request] | |||
| jobs: | |||
| main: | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| CYPRESS_PLUGIN_VISUAL_REGRESSION_UPDATE_IMAGES: ${{contains(github.event.head_commit.message, ' [update screenshots]')}} | |||
There was a problem hiding this comment.
I find out that there is no one-liner to get the last commit message, so I'm switching to a different strategy: commit e2e artifacts, and then the developer needs to manually pick the right screenshots and restart tests.
https://github.com/orgs/community/discussions/28474
| }); | ||
|
|
||
| on('task', { | ||
| changeVideoSource(videoSource) { |
There was a problem hiding this comment.
based on cypress-io/cypress#21188 (comment)
davidyuk
force-pushed
the
feature/sdk-13-partially
branch
2 times, most recently
from
8ac9635 to
33dba57
Compare
davidyuk
force-pushed
the
feature/sdk-13-partially
branch
3 times, most recently
from
f058983 to
5ba3e33
Compare
thepiwo
reviewed
May 30, 2023
| @@ -60,7 +60,7 @@ | |||
|
|
|||
| <script> | |||
| import { mapState } from 'vuex'; | |||
| import { SCHEMA } from '@aeternity/aepp-sdk'; | |||
| import { Tag } from '@aeternity/aepp-sdk-next'; | |||
There was a problem hiding this comment.
I would rename it back to @aeternity/aepp-sdk after finishing the update
|
What's the status of this PR? |
|
I would merge it after the next release |
davidyuk
force-pushed
the
feature/sdk-13-partially
branch
from
0a7de0a to
90ddbf9
Compare
davidyuk
force-pushed
the
feature/sdk-13-partially
branch
from
90ddbf9 to
0f3b34b
Compare
davidyuk
force-pushed
the
feature/sdk-13-partially
branch
from
a4558ad to
788e1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Crypto Foundation