Skip to content

Commit

Permalink
chore: remove outdated airbnb rules
Browse files Browse the repository at this point in the history
  • Loading branch information
davidyuk committed Feb 5, 2025
1 parent 4ecb0f2 commit 969a3f2
Show file tree
Hide file tree
Showing 15 changed files with 17 additions and 697 deletions.
13 changes: 5 additions & 8 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
ENV_MOBILE_DEVICE: true,
},
ignorePatterns: ['dist', 'platforms', 'plugins', 'www'],
extends: ['plugin:vue/recommended', 'plugin:@intlify/vue-i18n/recommended', '@vue/airbnb'],
extends: ['plugin:vue/recommended', 'plugin:@intlify/vue-i18n/recommended'],
rules: {
'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off',
'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off',
Expand Down Expand Up @@ -43,6 +43,10 @@ module.exports = {
'vuejs-accessibility/label-has-for': 'off',
'vuejs-accessibility/form-control-has-label': 'off',
'vue/multi-word-component-names': 'off',
'vue/max-attributes-per-line': 'off',
'vue/html-self-closing': 'off',
'vue/html-indent': 'off',
'vue/singleline-html-element-content-newline': 'off',
'vuejs-accessibility/no-autofocus': 'off',
'vuejs-accessibility/alt-text': 'off',
},
Expand All @@ -56,13 +60,6 @@ module.exports = {
jest: true,
},
},
{
files: 'backend/**',
rules: {
'import/no-extraneous-dependencies': ['error', { packageDir: 'backend' }],
'import/extensions': ['error', 'ignorePackages'],
},
},
],
settings: {
'vue-i18n': {
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/_validate-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
node-version: 20.x
cache: npm
- run: npm ci
working-directory: 'backend'
working-directory: backend
- run: npm test
working-directory: 'backend'
working-directory: backend
- run: npm ci --legacy-peer-deps # TODO: remove --legacy-peer-deps after updating dependencies
- run: docker compose up middleware -d --wait
- run: ./docker-compose/init-state.mjs
Expand All @@ -24,6 +24,6 @@ jobs:
if: failure()
with:
commit_message: 'fixme: update e2e screenshots'
file_pattern: 'tests/e2e/*.png'
file_pattern: tests/e2e/*.png
- run: docker compose logs
if: always()
6 changes: 3 additions & 3 deletions .github/workflows/pull-request-cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:
with:
DEPLOY_ENV: stg
DEPLOY_APP: ${{ github.event.repository.name }}
DEPLOY_VERSION: 'pr-${{ github.event.number }}'
DEPLOY_SUBDOMAIN: 'pr-${{ github.event.number }}-base'
DEPLOY_VERSION: pr-${{ github.event.number }}
DEPLOY_SUBDOMAIN: pr-${{ github.event.number }}-base
delete-tag:
uses: aeternity/github-actions/.github/workflows/[email protected]
secrets: inherit
with:
TAG: 'pr-${{ github.event.number }}'
TAG: pr-${{ github.event.number }}
cleanup:
uses: aeternity/github-actions/.github/workflows/[email protected]
needs: [delete-tag]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:
with:
DEPLOY_ENV: stg
DEPLOY_APP: ${{ github.event.repository.name }}
DEPLOY_VERSION: 'pr-${{ github.event.number }}'
DEPLOY_SUBDOMAIN: 'pr-${{ github.event.number }}-base'
DEPLOY_VERSION: pr-${{ github.event.number }}
DEPLOY_SUBDOMAIN: pr-${{ github.event.number }}-base
2 changes: 0 additions & 2 deletions cypress.config.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
const path = require('path');
const fs = require('fs');
const { defineConfig } = require('cypress');
// TODO: remove after fixing https://github.com/import-js/eslint-plugin-import/issues/1810
// eslint-disable-next-line import/no-unresolved
const { initPlugin } = require('@frsource/cypress-plugin-visual-regression-diff/plugins');

module.exports = defineConfig({
Expand Down
Loading

0 comments on commit 969a3f2

Please sign in to comment.