This one comes with a few caveats... #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Ditched the id and with block - values cached in global scope 2. Rewrite the table contents every blur 3. Fixed: Plain strings in cells were throwing an exception Cons: 1. Because the table is rewritten onblur, tabbing no longer works and you have to click twice to edit another cell. 2. Bad cell values or formulas will cause the table to fail to render until you manually clear the value from localStorage
|
Nice rewrite and down to 281! Just had t call But in my opinion, it is too hard to use, because you can't just click another cell to edit. |
|
Well done getting this to 281. @aemkei: I tried the same approach and found that rewriting the table onblur made the spreadsheet way TOO hard to use. Thus I did not even commit, push, pull-request |
|
I agree that this makes it hard to use, probably not a good idea to merge this in its current state. I had an earlier version that was around 287 so I'll revert this pull request back to that when I have time later today. Thanks for taking a look guys |
Changes: 1. Append 'i' to the input id so it can be referenced in addition to the calculated value for a cell in the global scope. This eliminates with(t) and shaves a few bytes. 2. replace(/^=?/,"=") is the smallest way I've found yet to normalize formulas before the eval. The string issue still exists however - fixing will add some bytes back... 3. rely on the first param of A() to denote the first iteration for building the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Cons: