WIP: Feat/book series info #3839
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main reason the series page doesn't already exist is because I couldn't think of a good UI for it. Can you add some screenshots of what you are thinking it would look like? |
|
I was thinking of just adding the information to the existing series pages. Is there a reason we can't do that? My thought was the description and other metadata can go above the items in the series as text blocks. I don't have any screenshots of what that would look like, but I do have screenshots of the new Edit Series option and the modal. |
|
That was the part I couldn't get to look right. Just adding the description above the list of books. I tried it a while back and it looked strange and couldn't think of a good design for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a number of requests for enhancements to Series pages, so I'm working on some simple changes, starting first with showing a Series description. I've added a new context menu item on the series pages, which displays a modal for editing the series, but so far it's just the UI.
Is there an API endpoint for updating a series? I've been looking, and have found the routes for getting all series in a library or a specific series in a library, but nothing for updating.
Related issues:
#711 #3806