Feed episode IDs changing on refresh & several other refresh issues #3772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Feed episodes were dropping and re-creating the table record anytime a feed needed to be updated. Since the generated RSS feed uses the content url as the GUID this was changing on every update causing podcast clients to think it is a new episode.
Which issue is fixed?
#3757
In-depth Description
To fix this the existing
FeedEpisode
records are loaded and thefilePath
is compared to see if aFeedEpisode
should be updated. So if the filepath changes then the generated RSS feed guid will change.Another option could be using the inode value but this would require storing the inode value in the
FeedEpisode
model and would cause issues for users using a file system that doesn't support unique inode values.This fixes 3 other issues that I found while testing.
How have you tested this?
Opened a feed for a podcast, an audiobook, a collection and a series. Tested adding/removing/updating the entity and child entities.