Resolved a server crash when a playback session lacked media metadata #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary
This PR introduces optional operators to allow stats to function without media metadata for playback Sessions. This change prevents server crashes when media metadata is absent.
In-depth Description
The logic for handling authors, narrators, genres has been updated to handle cases where
mediaMetadatais absent. This ensures that the server can generate responses without requiring metadata, thereby preventing crashes.A follow-up PR should be made to pull the
mediaMetadatawhen missing from request.How Have You Tested This?
Tested on a personal server.