Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Seasons UI to Podcast Page #2717

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mfcar
Copy link
Contributor

@mfcar mfcar commented Mar 6, 2024

This PR updates the interface for a podcast when the type is set to 'serial'.

When a podcast is of the 'serial' type, some changes are made on the page:

  • A new dropdown is displayed to filter by a specific season.
  • All the seasons are grouped in collapse/expand groups.
  • The initial state for the collapse/expand groups is closed, but the most recent season is displayed as open initially.
  • The number of episodes is shown on each group header.
  • Filters for episode status (complete, in progress, and incomplete) are functional.
  • In the grouping, if an episode doesn't contain the season information, it will be grouped under an 'unknown' season.
  • Two new phrases have been added for use in the season dropdown filter:
    • "LabelAllSeasons": "All Seasons"
    • "LabelSeasonUnknown": "Season Unknown"

Screenshots:

Screenshot 2024-03-06 at 16 27 32

Serial (seasons) vs Episodic UI

Demo

Screen.Recording.2024-03-06.at.15.47.39.mov

Known issues

Before removing the draft status, there are two known issues that I am trying to understand:

  • The first issue is related to lazy loading. Occasionally, the episodes listing starts to behave erratically and does not load properly. Additionally, the most recent episode of the first season consistently appears as blank.
Screen.Recording.2024-03-06.at.15.48.38.mov

  • The second issue is associated with sorting. While changing the sorting criteria (for example, from Title to PubDate) works as expected, changing the direction of a sort item results in all episodes appearing as blank. I suspected this is related to lazy loading, which loads episodes by index (I don't know if we can change the lazy loading to use episode ID instead a list index).
Screen.Recording.2024-03-06.at.15.49.15.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant