253 implement fault tolerance mechanisms eg retries dead letter queues circuit breakers e5 #280
+1,138
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndefokou
requested review from
IngridPuppet,
Hermann-Core and
Christiantyemele
|
Have you implemented the circuit breaker logic? I didn't see it. |
crates/web-plugins/didcomm-messaging/protocols/forward/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/forward/src/handler.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/mediator-coordination/src/handler/stateful.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/mediator-coordination/src/handler/stateful.rs
Outdated
Show resolved
Hide resolved
crates/web-plugins/didcomm-messaging/protocols/pickup/src/handler.rs
Outdated
Show resolved
Hide resolved
|
@IngridPuppet Please the test on the pickup are very slow and are not working correctly please can you help me to solve that |
Blindspot22
approved these changes
Dec 20, 2024
…olerance-mechanisms-eg-retries-dead-letter-queues-circuit-breakers-e5
…olerance-mechanisms-eg-retries-dead-letter-queues-circuit-breakers-e5
…breakers management
…d-letter-queues-circuit-breakers-e5' of https://github.com/adorsys/didcomm-mediator-rs into 253-implement-fault-tolerance-mechanisms-eg-retries-dead-letter-queues-circuit-breakers-e5
…olerance-mechanisms-eg-retries-dead-letter-queues-circuit-breakers-e5
Blindspot22
requested changes
Feb 3, 2025
| let next = checks( | ||
| &message, | ||
| &repository.connection_repository, | ||
| state.circuit_breaker.get(MEDIATE_FORWARD_2_0).as_deref(), |
There was a problem hiding this comment.
Here, if the circuit breaker is not correctly configured, the fallback (None) could skip validation. This could unintentionally bypass safety checks.
suggestion
Add logging or a fallback mechanism that fails securely if the circuit breaker is misconfigured.
There was a problem hiding this comment.
What do you mean? The circuit has nothing to do with the checks logic. Take a look at the checks function implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hermann-Core @Christiantyemele @IngridPuppet