feat: add site competitors array to site entity

[alinarublea]

Please ensure your pull request adheres to the following guidelines:

• make sure to link the related issues in this description
• when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

[github-actions]

This PR will trigger a minor release when merged.

[solaris007]

i am not sure the collection methods are optimal, as modifying competitors is a record-, not collection-level concern. also, i think the management of the competitors list should be done outside the data layer. possibly the schema could validate that there's no duplicates (with the Set apporach).

[solaris007]

if the attribute is not required, we should not check for array unless a value is present.

[solaris007]

this will not work, you'd have to call site.setSiteCompetitors(updatedCompetitors) - please validate in IT test

also, you could use a set to make things easier:

  const competitors = new Set(site.getSiteCompetitors());
  if (!competitors.has(siteCompetitorBaseURL)) {
    competitors.add(siteCompetitorBaseURL);
    site.setSiteCompetitors([...competitors]);
    await site.save();
  }

[solaris007]

this will not work, you'd have to call site.setSiteCompetitors(updatedCompetitors) - please validate in IT test

you could use a set to make things easier:

  const competitors = new Set(site.getSiteCompetitors());
  if (competitors.has(siteCompetitorBaseURL)) {
    competitors.delete(siteCompetitorBaseURL);
    site.setSiteCompetitors([...competitors]);
    await site.save();
  }